Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][docs] Document _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION #115405

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

aDotInTheVoid
Copy link
Contributor

This was added in 681cde7, but isn't currently documented.

@aDotInTheVoid aDotInTheVoid requested a review from a team as a code owner November 8, 2024 01:05
Copy link

github-actions bot commented Nov 8, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 8, 2024
@llvmbot
Copy link

llvmbot commented Nov 8, 2024

@llvm/pr-subscribers-libcxx

Author: Alona Enraght-Moony (aDotInTheVoid)

Changes

This was added in 681cde7, but isn't currently documented.


Full diff: https://github.com/llvm/llvm-project/pull/115405.diff

1 Files Affected:

  • (modified) libcxx/docs/UserDocumentation.rst (+3)
diff --git a/libcxx/docs/UserDocumentation.rst b/libcxx/docs/UserDocumentation.rst
index 1db437ce58b95e..2c1bc1373659c3 100644
--- a/libcxx/docs/UserDocumentation.rst
+++ b/libcxx/docs/UserDocumentation.rst
@@ -156,6 +156,9 @@ C++17 Specific Configuration Macros
 **_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE**:
   This macro is used to re-enable the `random_shuffle` algorithm.
 
+**_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION**:
+  This macro is used to re-enable `unary_function` and `binary_function`.
+
 **_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS**:
   This macro is used to re-enable `set_unexpected`, `get_unexpected`, and
   `unexpected`.

@philnik777 philnik777 merged commit 0a7e5e3 into llvm:main Nov 8, 2024
63 of 66 checks passed
Copy link

github-actions bot commented Nov 8, 2024

@aDotInTheVoid Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@aDotInTheVoid aDotInTheVoid deleted the patch-1 branch November 8, 2024 11:42
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
…CTION (llvm#115405)

This was added in 681cde7, but isn't
currently documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants